Added wrapper for OpenSSL 1.0.1 issue on 14.04 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones6
approved these changes
Jul 30, 2018
Contributor
djones6
left a comment
djones6
left a comment
There was a problem hiding this comment.
Looks good to me, and compiles + passes the BlueRSA tests on 14.04 / 16.04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue causing a failure when 14.04 used OpenSSL 1.0.1, due to the signature of a method changing. Swift would throw an error, so a wrapper in this PR has fixed the issue.
For reference, heres the failing Travis build: https://travis-ci.org/IBM-Swift/BlueRSA/jobs/396377103
And here is a new build on a new PR for BlueRSA, using the branch: https://travis-ci.org/IBM-Swift/BlueRSA/jobs/408132429