Port OpenSSL 2.x changes to OpenSSL 1.x #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones6
reviewed
Dec 10, 2018
djones6
suggested changes
Dec 10, 2018
Contributor
djones6
left a comment
djones6
left a comment
There was a problem hiding this comment.
Please restore the Package.swift to the old Swift 3 format. Otherwise, looks good.
Since there is no Travis, can you run a build of a dependent project (eg. BlueSSLService or Swift-JWK-to-PEM) using your branch, and link the passing Travis build here?
nethraravindran
force-pushed
the
toolsVersion40
branch
from
d76d521 to
160daae
Compare
billabt
approved these changes
Dec 11, 2018
Collaborator
|
@djones6 As soon as you're satisfied, I'll do the merge and tag it... Thanks. |
djones6
approved these changes
Dec 11, 2018
Contributor
|
@nethraravindran thanks for the testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.