Skip to content

Fix kernels_output() #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2025
+7 −7
Merged

Fix kernels_output() #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd97bce
Fix kernels output
stevemessick Mar 14, 2025
82925bc
typo
stevemessick Mar 14, 2025
ddd150d
typo
stevemessick Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kaggle/api/kaggle_api_extended.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2782,9 +2782,9 @@ def kernels_output(self, kernel, path, force=False, quiet=True):

outfiles = []
for item in response.files:
outfile = os.path.join(target_dir, item['fileName'])
outfile = os.path.join(target_dir, item.file_name)
outfiles.append(outfile)
download_response = requests.get(item['url'], stream=True)
download_response = requests.get(item.url, stream=True)
if force or self.download_needed(download_response, outfile, quiet):
os.makedirs(os.path.split(outfile)[0], exist_ok=True)
with open(outfile, 'wb') as out:
Expand Down
4 changes: 2 additions & 2 deletions src/kaggle/api/kaggle_api_extended.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2782,9 +2782,9 @@ def kernels_output(self, kernel, path, force=False, quiet=True):

outfiles = []
for item in response.files:
outfile = os.path.join(target_dir, item['fileName'])
outfile = os.path.join(target_dir, item.file_name)
outfiles.append(outfile)
download_response = requests.get(item['url'], stream=True)
download_response = requests.get(item.url, stream=True)
if force or self.download_needed(download_response, outfile, quiet):
os.makedirs(os.path.split(outfile)[0], exist_ok=True)
with open(outfile, 'wb') as out:
Expand Down
2 changes: 2 additions & 0 deletions tests/test_commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ kaggle kernels push -p tests/kernel
rm -f tests/kernel/exercise-as-with.ipynb tests/kernel/kernel-metadata.json exercise-as-with.ipynb
echo "kaggle kernels status"
kaggle k status kerneler/sqlite-global-default
echo "kaggle kernels output"
kaggle k output kerneler/sqlite-global-default -f

echo "kaggle datasets list"
kaggle d list --size 10
Expand Down
4 changes: 1 addition & 3 deletions tests/unit_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,8 @@ def test_kernels_e_list_files(self):

def test_kernels_f_output(self):
fs = []
if self.kernel_slug == '':
self.test_kernels_c_push()
try:
fs, token = api.kernels_output(self.kernel_slug, 'kernel/tmp')
fs, token = api.kernels_output('kerneler/sqlite-global-default', 'kernel/tmp')
self.assertIsInstance(fs, list)
if token:
print(token)
Expand Down