forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Labels
[Bug] Race ConditionA race condition needs to be fixedA race condition needs to be fixed[PATCH] ExistsA patch exists to address the issueA patch exists to address the issuegood first issueGood for newcomersGood for newcomers
Description
There are race conditions around ptrace_may_access() that can lead to various confidentiality exposures.
v1: https://lore.kernel.org/linux-fsdevel/[email protected]/
v2: https://lore.kernel.org/linux-fsdevel/[email protected]/
v3: https://lore.kernel.org/linux-fsdevel/[email protected]/
It looks like these steps are needed:
- https://lore.kernel.org/linux-fsdevel/[email protected]/ was implemented differently with task->signal->exec_update_lock in commit eea9673 (v5.7) and converted to a semaphore in commit f7cfd87 (v5.11)
- rewrite https://lore.kernel.org/linux-fsdevel/[email protected]/ to use
down_read_killable(&task->signal->exec_update_lock) - rewrite https://lore.kernel.org/linux-fsdevel/[email protected]/ to use the
__mem_openopener andfile->private_data != current->mmas the confused deputy check for each of at least:- do_task_stat
- proc_pid_wchan
- proc_pid_stack
- rewrite https://lore.kernel.org/linux-fsdevel/[email protected]/ to use
down_read_killable(&task->signal->exec_update_lock) - https://lore.kernel.org/linux-fsdevel/[email protected]/ was fixed (ultimately) with commit 94f0b2d (v5.13)
- figure out what's needed for https://lore.kernel.org/linux-fsdevel/[email protected]/
- refresh https://lore.kernel.org/linux-fsdevel/[email protected]/
Metadata
Metadata
Assignees
Labels
[Bug] Race ConditionA race condition needs to be fixedA race condition needs to be fixed[PATCH] ExistsA patch exists to address the issueA patch exists to address the issuegood first issueGood for newcomersGood for newcomers