Skip to content

Conversation

@memark
Copy link
Contributor

@memark memark commented Oct 6, 2024

This PR updates the code to eliminate some type problems with React 19 RC.

  • Use React.JSX instead of global JSX.
  • Use React.ReactNode instead of React.ReactChild

Copy link
Owner

@JustFly1984 JustFly1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, instead on prefixing React. everywhere, just import it on top of the file

import type { JSX } from 'react'

@memark
Copy link
Contributor Author

memark commented Oct 8, 2024

Sure thing. Done!

@JustFly1984 JustFly1984 merged commit b383fb0 into JustFly1984:develop Oct 8, 2024
@JustFly1984
Copy link
Owner

@memark thank you for your PR. merged. Will try to find the time to release new version soon. I guess it need to bump peerDependencies too for react@19. please create one more PR. PS there is more than one package.

@JustFly1984
Copy link
Owner

PS2: I'm going to bring some love to this package soon, gonna replace gatsby.js with Vite, and maybe publish docs on Vite too. So no point to update gatsbyjs.

@memark memark deleted the prepare-react-19 branch October 8, 2024 18:40
@JustFly1984
Copy link
Owner

released 2.20.1

@memark if you want to help more, I have a branch upgrade, which I've used to release 2.20.0 and 2.20.1

We currently having issues with react-styleguidist, and it is refuses to start, I guess due to some esm/cjs inconsistencies.

I've spent yesteday to bring some love to the project, and half of today, but I have no time anymore. If you could fix styleguidist, or replace it with other docs, I would love to deploy it again. Else, I don't know then next time I will have time to bring more love to the project.

This was referenced Oct 12, 2024
@memark
Copy link
Contributor Author

memark commented Oct 12, 2024

I tried giving it a little love, but got no further. No combination of downgrading the styleguidist or docgen packages helped at all. Neither did removing our styleguide config. I haven't worked with Rollup/Webpack in years, so this will be difficult for me.

Do you have any idea when build:docs worked the last time?

@JustFly1984
Copy link
Owner

@memark It was broken since react@17 support added. It has been broken since.
I'm more inclined to use docosaurus at this point and get rid of styleguidist at all.

@brunocoelho
Copy link

Thanks for giving this project some attention @JustFly1984. Your work here is very valuable. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants