-
-
Notifications
You must be signed in to change notification settings - Fork 463
Prepare for React 19 #3382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for React 19 #3382
Conversation
JustFly1984
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, instead on prefixing React. everywhere, just import it on top of the file
import type { JSX } from 'react'
|
Sure thing. Done! |
|
@memark thank you for your PR. merged. Will try to find the time to release new version soon. I guess it need to bump peerDependencies too for react@19. please create one more PR. PS there is more than one package. |
|
PS2: I'm going to bring some love to this package soon, gonna replace gatsby.js with Vite, and maybe publish docs on Vite too. So no point to update gatsbyjs. |
|
released 2.20.1 @memark if you want to help more, I have a branch upgrade, which I've used to release 2.20.0 and 2.20.1 We currently having issues with react-styleguidist, and it is refuses to start, I guess due to some esm/cjs inconsistencies. I've spent yesteday to bring some love to the project, and half of today, but I have no time anymore. If you could fix styleguidist, or replace it with other docs, I would love to deploy it again. Else, I don't know then next time I will have time to bring more love to the project. |
|
I tried giving it a little love, but got no further. No combination of downgrading the styleguidist or docgen packages helped at all. Neither did removing our styleguide config. I haven't worked with Rollup/Webpack in years, so this will be difficult for me. Do you have any idea when |
|
@memark It was broken since react@17 support added. It has been broken since. |
|
Thanks for giving this project some attention @JustFly1984. Your work here is very valuable. ❤️ |
This PR updates the code to eliminate some type problems with React 19 RC.
React.JSXinstead of globalJSX.React.ReactNodeinstead ofReact.ReactChild