Skip to content

Conversation

@Drvi
Copy link
Collaborator

@Drvi Drvi commented Mar 25, 2024

Backport of #1161

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-1.9@f20777d). Click here to learn what that means.

Files Patch % Lines
src/Servers.jl 77.77% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.9    #1162   +/-   ##
==============================================
  Coverage               ?   82.49%           
==============================================
  Files                  ?       32           
  Lines                  ?     3056           
  Branches               ?        0           
==============================================
  Hits                   ?     2521           
  Misses                 ?      535           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Drvi
Copy link
Collaborator Author

Drvi commented Mar 25, 2024

I think release-1.9 is missing some fixes by Jameson which makes master pass on nightly (#1146, #1148, #1149)

@Drvi Drvi requested a review from quinnj March 25, 2024 16:54
@Drvi
Copy link
Collaborator Author

Drvi commented Mar 26, 2024

@quinnj Would you be ok with merging this backport?

@quinnj
Copy link
Member

quinnj commented Mar 26, 2024

Sure thing; go ahead

@Drvi Drvi merged commit 3a79e9a into release-1.9 Mar 26, 2024
@Drvi Drvi deleted the td-lock-connections-mutation-1.9 branch March 26, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants