Do not migrate tasks to a different thread pool #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1159 +/- ##
=======================================
Coverage 82.62% 82.62%
=======================================
Files 32 32
Lines 3051 3051
=======================================
Hits 2521 2521
Misses 530 530 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@quinnj Let me know if there are any more changes you would like here before it can be merged? Thanks :) |
quinnj
approved these changes
Mar 16, 2024
Drvi
added a commit
that referenced
this pull request
Dec 12, 2024
Drvi
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on ConcurrentUtilities#32. Therefore, I don't expect unit tests to pass until ConcurrentUtilities#32 is merged, and a new version of ConcurrentUtilities is released.
Together with ConcurrentUtilities#32, this fixes #1153.