refactor: make Equation latexification more modular
#1549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/modular-latexify
branch
from
1771ac1 to
636d870
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1549 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 51 51
Lines 5136 5136
=======================================
Hits 4139 4139
Misses 997 997 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AayushSabharwal
force-pushed
the
as/modular-latexify
branch
from
636d870 to
34895c1
Compare
| @latexrecipe function f(eqs::Vector{Equation}) | ||
| index --> :subscript | ||
| has_connections = any(x->x.lhs isa Connection, eqs) | ||
| has_connections = any(x -> hide_lhs(x.lhs), eqs) |
There was a problem hiding this comment.
hide_lhs isn't defined?
There was a problem hiding this comment.
ChrisRackauckas
merged commit 7b2c0b1
into
JuliaSymbolics:master
15 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for SciML/ModelingToolkit.jl#3658