Skip to content

fix: tuples and arrays of Symbols should not be considered symbolic in codegen #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

AayushSabharwal
Copy link
Member

No description provided.

Copy link
Contributor

github-actions bot commented Apr 1, 2025

Benchmark Results

master 3b5094e... master/3b5094e6cb2476...
overhead/acrule/a+2 1.01 ± 0.32 μs 0.977 ± 0.32 μs 1.04
overhead/acrule/a+2+b 1.19 ± 0.34 μs 1.17 ± 0.32 μs 1.02
overhead/acrule/a+b 0.283 ± 0.07 μs 0.273 ± 0.035 μs 1.04
overhead/acrule/noop:Int 2.47 ± 0.01 ns 1.55 ± 0.01 ns 1.59
overhead/acrule/noop:Sym 27.7 ± 6.1 ns 21.9 ± 6.3 ns 1.27
overhead/rule/noop:Int 0.0364 ± 0.026 μs 0.0356 ± 0.025 μs 1.02
overhead/rule/noop:Sym 0.0417 ± 0.025 μs 0.0334 ± 0.025 μs 1.25
overhead/rule/noop:Term 0.0349 ± 0.024 μs 0.0335 ± 0.025 μs 1.04
overhead/ruleset/noop:Int 0.12 ± 0.0097 μs 0.115 ± 0.0036 μs 1.05
overhead/ruleset/noop:Sym 0.125 ± 0.012 μs 0.124 ± 0.0042 μs 1.01
overhead/ruleset/noop:Term 4.48 ± 0.82 μs 4.44 ± 0.2 μs 1.01
overhead/simplify/noop:Int 0.244 ± 0.036 μs 0.296 ± 0.033 μs 0.825
overhead/simplify/noop:Sym 0.269 ± 0.033 μs 0.3 ± 0.033 μs 0.896
overhead/simplify/noop:Term 0.0399 ± 0.0064 ms 0.0392 ± 0.0025 ms 1.02
overhead/simplify/randterm (+, *):serial 0.0971 ± 0.0052 s 0.0964 ± 0.0048 s 1.01
overhead/simplify/randterm (+, *):thread 0.058 ± 0.0081 s 0.0583 ± 0.0065 s 0.994
overhead/simplify/randterm (/, *):serial 0.212 ± 0.027 ms 0.208 ± 0.024 ms 1.02
overhead/simplify/randterm (/, *):thread 0.241 ± 0.028 ms 0.241 ± 0.021 ms 1
overhead/substitute/a 0.105 ± 0.012 ms 0.101 ± 0.013 ms 1.04
overhead/substitute/a,b 0.0903 ± 0.0082 ms 0.0866 ± 0.0093 ms 1.04
overhead/substitute/a,b,c 20.9 ± 2.5 μs 20.9 ± 2.4 μs 1
polyform/easy_iszero 0.0417 ± 0.0062 ms 0.0394 ± 0.0021 ms 1.06
polyform/isone 2.79 ± 0.009 ns 3.1 ± 0.01 ns 0.903
polyform/iszero 1.38 ± 0.039 ms 1.35 ± 0.027 ms 1.02
polyform/simplify_fractions 1.87 ± 0.062 ms 1.83 ± 0.045 ms 1.03
time_to_load 1.08 ± 0.011 s 1.06 ± 0.01 s 1.02

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@AayushSabharwal AayushSabharwal merged commit d7afd4f into JuliaSymbolics:master Apr 2, 2025
16 checks passed
@AayushSabharwal AayushSabharwal deleted the as/cse-fix branch April 2, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant