Skip to content

Conversation

@Mytolo
Copy link
Contributor

@Mytolo Mytolo commented Jul 10, 2023

the pettingzoo environment previously featured both simultaneous and sequential trait of DynamicStyle. For the use in JuliaRL i focus on simultaneous style.

PR Checklist

  • Update NEWS.md?
  • Unit tests for all structs / functions?
  • Integration and correctness tests using a simple env?
  • PR Review?
  • Add or update documentation?
  • Write docstrings for new methods?

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #925 (a81254f) into main (3182026) will decrease coverage by 10.67%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #925       +/-   ##
===========================================
- Coverage   24.30%   13.64%   -10.67%     
===========================================
  Files         221      217        -4     
  Lines        7742     7571      -171     
===========================================
- Hits         1882     1033      -849     
- Misses       5860     6538      +678     
Impacted Files Coverage Δ
...ironments/src/environments/3rd_party/pettingzoo.jl 0.00% <0.00%> (ø)
...Environments/src/environments/3rd_party/structs.jl 66.66% <ø> (ø)

... and 23 files with indirect coverage changes

@jeremiahpslewis
Copy link
Member

Looks good to me. @HenriDeh you ok with the PR?

@HenriDeh
Copy link
Member

I think so, I'm not familiar with pettingzoo or pycall so I'll trust you and @Mytolo

@jeremiahpslewis jeremiahpslewis merged commit 1f7f347 into JuliaReinforcementLearning:main Jul 18, 2023
@jeremiahpslewis
Copy link
Member

jeremiahpslewis commented Jul 18, 2023

Merged, thanks @Mytolo!

Mytolo added a commit to Mytolo/ReinforcementLearning.jl that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants