Skip to content

Conversation

@tkf
Copy link
Member

@tkf tkf commented Sep 25, 2020

I think this makes [compat] compliant with the automatic merging condition of JuliaRegistries/General: https://github.com/JuliaRegistries/General#automatic-merging-of-pull-requests

@malmaud
Copy link
Collaborator

malmaud commented Sep 29, 2020

Thanks! Is there some way to test that this works before merging it?

@tkf
Copy link
Member Author

tkf commented Sep 29, 2020

Not sure what the standard way to check this but I worte Aqua.test_deps_compat to check that. It now works with Pandas.jl:

julia> Aqua.test_deps_compat(Pandas)
Test Summary:                                 | Pass  Total
Pandas [eadc2687-ae89-51f9-a5d9-86b5a6373a9c] |    1      1
1-element Vector{Any}:
 Test.DefaultTestSet("Pandas [eadc2687-ae89-51f9-a5d9-86b5a6373a9c]", Any[], 1, false)

(Pandas) pkg> st
Project Pandas v1.4.0
Status `~/.julia/dev/Pandas/Project.toml`
  [34da2185] Compat
  [e7dc6d0d] DataValues
  [82899510] IteratorInterfaceExtensions
  [50d2b5c4] Lazy
  [438e738f] PyCall
  [3783bdb8] TableTraits
  [382cd787] TableTraitsUtils
  [44cfe95a] Pkg
  [10745b16] Statistics
  [8dfed614] Test

shell> git log -n1
commit b7124eae813421a5112f7d998027930b258e74a1 (HEAD -> compat, tkf/compat)
Author: Takafumi Arakaki <[email protected]>
Date:   Fri Sep 25 19:11:10 2020 -0700

    Remove redundant compat

If you just want to check the status of master branch, installing https://github.com/JuliaRegistries/CompatHelper.jl (and hit the workflow dispatch button) is probably the easiest.

@malmaud
Copy link
Collaborator

malmaud commented Sep 29, 2020

Great, thanks.

@malmaud malmaud merged commit de05d58 into JuliaPy:master Sep 29, 2020
@tkf tkf deleted the compat branch September 29, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants