-
Notifications
You must be signed in to change notification settings - Fork 24
Removed Ix indexer and updated Index/MultiIndex path #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for this fix! Is this still backwards-compatible with pre-1.0.0 pandas? |
|
I've resolved the Travis errors on #63. |
Technically, there are two changes in this PR:
The Ix indexer has been deprecated by Pandas for several years and finally they removed it in 1.0.0. Since we're removing functionality, I would say it's backward compatible. The second change is unlikely going to be compatible since the paths to find the Python classes are different. Unless we want to support both pre- and post-1.0 configurations with the same code, I would suggest that we put something in the README and ask people to pin the release if they need to use an older version of Pandas.
I suppose that you mean the Travis error here :-) I think the dependent Python package is |
|
Oh, I see what you mean about the Travis fix in #63. It seems odd that it used to work before. P.S. I was a bit confused earlier. It looks like the package is named |
Yes, although that was 7 months ago. One of the dependencies could have changed, or as has happened to me before, Travis could have changed something with their setup. |
|
Ok, I'll check it out today. |
|
Thanks! |
|
Thanks for this PR! If it's not too hard, I think I'd like to see if we can get this backwards-compatible. I'll try adding a commit to this since it doesn't look like it will be too hard. |
|
That's great! It's the best of both worlds! Thanks @malmaud |
Fixes #64