Skip to content

Test suite: Add coverage for some "unhappy" paths (error paths) #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Feb 7, 2025

No description provided.

@DilumAluthge DilumAluthge force-pushed the dpa/more-ci-coverage branch 2 times, most recently from 3ce5d00 to fe1c317 Compare February 7, 2025 20:26
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.61%. Comparing base (e49016d) to head (a0dfcfd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   90.42%   93.61%   +3.19%     
==========================================
  Files           2        2              
  Lines          94       94              
==========================================
+ Hits           85       88       +3     
+ Misses          9        6       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DilumAluthge DilumAluthge force-pushed the dpa/warn_if_unexpected_params-2 branch from 02461ec to df626ee Compare February 9, 2025 20:31
@DilumAluthge DilumAluthge force-pushed the dpa/more-ci-coverage branch 2 times, most recently from 3e8d640 to 346dd24 Compare February 9, 2025 22:07
@DilumAluthge DilumAluthge force-pushed the dpa/warn_if_unexpected_params-2 branch from 540e0a1 to 344d45c Compare February 9, 2025 22:12
@DilumAluthge DilumAluthge force-pushed the dpa/warn_if_unexpected_params-2 branch from 344d45c to 19e1470 Compare February 9, 2025 22:19
@DilumAluthge DilumAluthge force-pushed the dpa/warn_if_unexpected_params-2 branch from 19e1470 to 1feb0b2 Compare February 19, 2025 00:29
Base automatically changed from dpa/warn_if_unexpected_params-2 to dpa/ntasks April 29, 2025 04:06
@DilumAluthge DilumAluthge changed the base branch from dpa/ntasks to master April 29, 2025 04:09
@DilumAluthge DilumAluthge force-pushed the dpa/more-ci-coverage branch 2 times, most recently from f3e0e4e to 100fbf3 Compare May 1, 2025 02:17
@DilumAluthge DilumAluthge marked this pull request as ready for review May 1, 2025 02:18
@DilumAluthge DilumAluthge requested a review from kleinhenz May 1, 2025 02:25
@DilumAluthge
Copy link
Member Author

@kleinhenz This one is now ready for review. It increases the code coverage by adding tests for some of the error paths.

@DilumAluthge DilumAluthge force-pushed the dpa/more-ci-coverage branch from c552e64 to a0dfcfd Compare May 1, 2025 03:18
@DilumAluthge DilumAluthge merged commit 11d491c into master May 1, 2025
6 checks passed
@DilumAluthge DilumAluthge deleted the dpa/more-ci-coverage branch May 1, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants