fix artifacts download url when --deploy=local
#1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@giordano for a review, maybe ? |
Merged
giordano
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1241, which I also hit while working on JuliaPackaging/Yggdrasil#11052.
I also took the liberty of removing the exported symbol
print_artifacts_tomlsince it appeared nowhere, should we do the same forbuild?Added test.
Locally, the artifact is correctly downloaded and used after a local build:
julia build_tarballs.jl x86_64-linux-gnu --verbose --deploy=local, and tested in theGRtest suite with the resultingGR_jlldev'ed.