Skip to content

set(arr, reverse, arr2) can change size #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

set(arr, reverse, arr2) can change size #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2412f3a
`set(arr, reverse, arr)` can change size
jariji Sep 13, 2025
cdc0df3
Add reverse methods for KeyedArray
jariji Sep 13, 2025
3e0694d
Fix
jariji Sep 13, 2025
5240f45
Fix
jariji Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ext/AxisKeysExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,11 @@ Accessors.set(x::KeyedArray, f::Base.Fix2{typeof(axiskeys), Int}, v) = @set axis
Accessors.set(x::KeyedArray, f::Base.Fix2{typeof(axiskeys), Symbol}, v) = @set named_axiskeys(x)[f.x] = v

Accessors.set(x::KeyedArray, ::typeof(AxisKeys.keyless_unname), v::AbstractArray) = KeyedArray(v; named_axiskeys(x)...)

function set(x::KeyedArray, ::typeof(reverse), v::AbstractVector)
res = similar(x, eltype(v))
res .= v
reverse!(res)
res
end
end
6 changes: 6 additions & 0 deletions src/functionlenses.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@ function set(x::AbstractVector, ::typeof(reverse), v)
reverse!(res)
res
end
function set(x::AbstractVector, ::typeof(reverse), v::AbstractVector)
res = similar(x, eltype(v), size(v))
res .= v
reverse!(res)
res
end


set(obj, o::Base.Fix1{typeof(map)}, val) = map((ob, v) -> set(ob, o.x, v), obj, val)
Expand Down
1 change: 1 addition & 0 deletions test/test_functionlenses.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ end
@test set([1, 2], reverse, (3, 4)) == [4, 3]
@test set((1, 2), reverse, [3, 4]) === (4, 3)
@test set((a=1, b=2), reverse, [3, 4]) === (a=4, b=3)
@test set([1, 2, 3], reverse, [5, 6]) == [6, 5]

C = KeyedArray([1,2,3], x=[:a, :b, :c])
@test (@set vec(C) = [5,6,7])::KeyedArray == KeyedArray([5,6,7], x=[:a, :b, :c])
Expand Down
Loading