Skip to content

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Jan 28, 2022

Update Select and Reject to add Regex support.

Fix #14

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022

Codecov Report

Merging #23 (c90e4aa) into master (7614fbd) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   92.19%   92.30%   +0.11%     
==========================================
  Files          14       14              
  Lines         346      351       +5     
==========================================
+ Hits          319      324       +5     
  Misses         27       27              
Impacted Files Coverage Δ
src/transforms/select.jl 96.22% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7614fbd...c90e4aa. Read the comment docs.

@eliascarv
Copy link
Member Author

This PR is ready for review @juliohm.

Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome progress. Please take a look at the attached suggestions.

Also, we should make sure that the Reject transform is also working with regex.

@eliascarv eliascarv changed the title New Select New Select and Reject Jan 29, 2022
Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. Just a few more changes before we can go ahead and merge.

@juliohm
Copy link
Member

juliohm commented Jan 30, 2022

Great contribution 👍🏽

@juliohm juliohm merged commit 004f158 into JuliaML:master Jan 30, 2022
@eliascarv eliascarv deleted the new-select branch January 30, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow regular expression in Select/Reject

3 participants