remove usage of 2-arg LA.AbstractTriangular
#146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
==========================================
+ Coverage 86.49% 86.52% +0.03%
==========================================
Files 10 10
Lines 1740 1744 +4
==========================================
+ Hits 1505 1509 +4
Misses 235 235
☔ View full report in Codecov by Sentry. |
dlfivefifty
requested changes
Jul 7, 2023
ararslan
reviewed
Jul 7, 2023
Co-authored-by: Alex Arslan <[email protected]>
dlfivefifty
approved these changes
Jul 11, 2023
KristofferC
pushed a commit
that referenced
this pull request
Apr 22, 2024
* remove usage of 2-arg `LA.AbstractTriangular` * fix * another fix * fix v1.9 * include review comments * Update Project.toml * Update src/ArrayLayouts.jl Co-authored-by: Alex Arslan <[email protected]> --------- Co-authored-by: Alex Arslan <[email protected]> (cherry picked from commit 32e5ab8)
jishnub
pushed a commit
that referenced
this pull request
Apr 23, 2024
* remove usage of 2-arg `LA.AbstractTriangular` (#146) * remove usage of 2-arg `LA.AbstractTriangular` * fix * another fix * fix v1.9 * include review comments * Update Project.toml * Update src/ArrayLayouts.jl Co-authored-by: Alex Arslan <[email protected]> --------- Co-authored-by: Alex Arslan <[email protected]> (cherry picked from commit 32e5ab8) * change an exact equality check to approximate * bump version --------- Co-authored-by: Daniel Karrasch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Late adaptation to JuliaLang/julia#26307.