-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
fix some crashy behavior of invoke with builtins
#59451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I guess this breaks trimming. would it be better for this to just be always an error |
|
this now solely turns internal errors into surface errors so I'm removing the |
|
with the clarification in |
vtjnash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are generic functions (or rather just functions, since Julia doesn't have any non-generic function). There's a mistake that slipped in to jl_specializations_get_linfo_ though, since it is supposed to return unspecialized if source and generated are both NULL, but it instead checks if it is a non-generic function (sig == jl_anytuple_type), but we don't have any non-generic functions.
7671422 to
ede7bde
Compare
|
thanks for the advice. does the latest version look closer to what you had in mind? |
builtins have empty method tables so `invoke` will segfault or otherwise crash (see some tests). this PR attempts to fix that (cherry picked from commit 1811564)
builtins have empty method tables so `invoke` will segfault or otherwise crash (see some tests). this PR attempts to fix that (cherry picked from commit 1811564)
builtins have empty method tables so
invokewill segfault or otherwise crash (see some tests). this PR attempts to fix that