lock: Specialize OncePerX more aggressively
#57660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidental regression from JuliaLang#57289, due to the different specialization rules for `Function` types. The `@noinline` bodies were inferring very poorly treating `once` as a `Function` instead of the much more specific `OncePerX{T,F}`.
Just to have a slightly more interesting "Hello, world!" and make sure that OncePerX trim-compatibility is covered in our tests somewhere.
topolarity
added
trimming
vtjnash
approved these changes
Mar 6, 2025
KristofferC
pushed a commit
that referenced
this pull request
Mar 20, 2025
Accidental regression from #57289. Due to the different specialization rules for `Function` types, the `@noinline` bodies were inferring very poorly treating `once` as a `Function` instead of the much more specific `OncePerX{T,F}`. Adds a trimming test case so that we don't regress again. (cherry picked from commit c93dd2d)
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidental regression from #57289. Due to the different specialization rules for
Functiontypes, the@noinlinebodies were inferring very poorly treatingonceas aFunctioninstead of the much more specificOncePerX{T,F}.Adds a trimming test case so that we don't regress again.