Skip to content

Fix goto insertion when dom-sorting IR in slot2ssa pass #56189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix goto insertion when dom-sorting IR in slot2ssa pass #56189

merged 1 commit into from
Oct 18, 2024

Conversation

@topolarity
Copy link
Member

@topolarity topolarity commented Oct 16, 2024 •
edited
Loading

Fix-up this pass a bit to correctly handle fall-through terminators that cannot have their BasicBlock extended
(e.g. Expr(:leave, ...))

@topolarity
Fix goto insertion when dom-sorting IR in slot2ssa pass
fd21a53 
This code wasn't fully handling fall-through terminators that cannot
have their BasicBlock extended.
@topolarity topolarity requested a review from Keno October 16, 2024 12:13
@oscardssmith oscardssmith added bugfix This change fixes an existing bug compiler:optimizer Optimization passes (mostly in base/compiler/ssair/) labels Oct 16, 2024
vtjnash
vtjnash reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Does this fix #55388?

@oscardssmith oscardssmith merged commit a64ffa3 into JuliaLang:master Oct 18, 2024
10 checks passed
@aviatesk
Copy link
Member

aviatesk commented Oct 18, 2024

Unfortunately this doesn't seem to fix #55388 .

KristofferC pushed a commit that referenced this pull request Oct 21, 2024
@topolarity
Fix goto insertion when dom-sorting IR in slot2ssa pass (#56189)
d352678 
Fix-up this pass a bit to correctly handle fall-through terminators that
cannot have their BasicBlock extended
(e.g. `Expr(:leave, ...)`)
@topolarity
Copy link
Member Author

topolarity commented Oct 21, 2024

Yeah, domsorting happens at the very end of slot2ssa, so whatever causing that issue happens prior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash left review comments

@Keno Keno Awaiting requested review from Keno

Assignees

No one assigned

Labels

bugfix This change fixes an existing bug compiler:optimizer Optimization passes (mostly in base/compiler/ssair/)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@topolarity @aviatesk @vtjnash @oscardssmith