doc: expand the <: doc string
#53001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Jan 22, 2024
Keno
reviewed
Jan 23, 2024
Keno
reviewed
Jan 23, 2024
nsajko
commented
Jan 24, 2024
jakobnissen
reviewed
Jan 25, 2024
nsajko
force-pushed
the
doc_subtype
branch
4 times, most recently
from
2a36b9d to
6de6b29
Compare
Member
Author
|
Is this OK now? |
adienes
reviewed
Feb 2, 2024
Member
Author
|
bump |
vtjnash
requested changes
Feb 12, 2024
vtjnash
reviewed
Feb 12, 2024
vtjnash
reviewed
Feb 12, 2024
base/operators.jl
Outdated
| Subtyping relation, defined between two types. The returned value is of type | ||
| `Bool`. | ||
| A type `S` is said to be a *subtype* of a type `T` if and only if we have `S <: T`. |
Member
There was a problem hiding this comment.
This is a tautology. I am not sure it helps to define <: in terms of itself.
Member
Author
There was a problem hiding this comment.
The idea was more to define what "subtype"/"subtyping" means in Julia in terms of <:. Not sure if it's better now.
fingolfin
reviewed
Feb 14, 2024
fingolfin
reviewed
Feb 14, 2024
Member
|
@nsajko thanks for the improvements, I like it! I left two more minor suggestions. |
Clear up some things, state some expected properties and limitations, add cross-references, add more examples.
Member
|
I believe this is ready for merging but let's see if @vtjnash is happy with it now :-) |
Member
|
I made a couple more style and linguistic updates. I think this is accurate and useful now |
vtjnash
approved these changes
Feb 16, 2024
Member
Author
|
merge? |
tecosaur
pushed a commit
to tecosaur/julia
that referenced
this pull request
Mar 4, 2024
Clear up some things, state some expected properties and limitations, add cross-references, add more examples. Co-authored-by: Jameson Nash <[email protected]>
mkitti
pushed a commit
to mkitti/julia
that referenced
this pull request
Mar 7, 2024
Clear up some things, state some expected properties and limitations, add cross-references, add more examples. Co-authored-by: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear up some things, state some expected properties and limitations, add cross-references, add more examples.