Skip to content

Conversation

@LilithHafner
Copy link
Member

@ViralBShah asked for this in #50103 (comment).

@LilithHafner LilithHafner added the docs This change adds or pertains to documentation label Jun 28, 2023
@LilithHafner LilithHafner requested a review from ViralBShah June 28, 2023 11:20
@ViralBShah ViralBShah added the merge me PR is reviewed. Merge when all tests are passing label Jun 28, 2023
@DilumAluthge
Copy link
Member

@LilithHafner Looks like there is some trailing whitespace that needs to be removed.

@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jun 28, 2023
@LilithHafner LilithHafner added the merge me PR is reviewed. Merge when all tests are passing label Jun 28, 2023
@ViralBShah
Copy link
Member

I thought the merge me label means merge whenever CI is green.

@LilithHafner LilithHafner merged commit 850dd87 into master Jun 28, 2023
@LilithHafner LilithHafner deleted the LilithHafner-patch-2 branch June 28, 2023 16:18
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs This change adds or pertains to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants