Skip to content

Conversation

@hexaeder
Copy link
Contributor

Hey all,

On current master, open(f, cmds::pipeline) does not forward an exception inf but throws a MethodError since waitkill is only defined for Process. This PR extends it to ProcessChain. Maybe the type specification could be dropped entirely...

cmd = pipeline(`sleep 100`, `echo "foo"`)
open(cmd) do out
    error("my error")
end
# throws MethodError

cmd = `sleep 100`
open(cmd) do out
    error("my error")
end
# throws "my error" as expected

Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(regression introduced by #44078)

@fredrikekre fredrikekre added backport 1.8 Change should be backported to release-1.8 backport 1.9 Change should be backported to release-1.9 labels Mar 27, 2023
@KristofferC KristofferC mentioned this pull request Mar 30, 2023
52 tasks
@KristofferC KristofferC merged commit 329f92c into JuliaLang:master Mar 30, 2023
KristofferC pushed a commit that referenced this pull request Mar 30, 2023
aviatesk pushed a commit that referenced this pull request Mar 30, 2023
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 31, 2023
Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.8 Change should be backported to release-1.8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants