Add GC.in_finalizer query #48857
Merged
Add GC.in_finalizer query #48857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The latest push fails on the added test, which I can reproduce in the REPL; @vtjnash any idea why this isn't working? |
vtjnash
reviewed
Mar 3, 2023
vtjnash
reviewed
Mar 3, 2023
Member
|
Is it to be expected that finalizer inlining may change the result of this function? If so, I think it would be good to at least document that fact |
Member
Author
|
@simeonschaub let me know what you think of the added docstring. |
Member
|
Looks great to me! |
jpsamaroo
force-pushed
the
jps/in-finalizer-no-sticky
branch
from
4ddf630 to
c811cf5
Compare
Member
Author
|
Latest push just squashes and rebases on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to skip setting the sticky bit of a parent task that calls
@asyncin a finalizer, along with also allowing resource cleanup finalizers to use a finalizer-compatible implementation only when necessary.