remove UndefVarError deprecation from v0.5 #40333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this got lost in deprecation removal?
KristofferC
approved these changes
Apr 3, 2021
simeonschaub
reviewed
Apr 3, 2021
|
|
||
| function showerror(io::IO, ex::UndefVarError) | ||
| print(io, "UndefVarError: $(ex.var) not defined") | ||
| Experimental.show_error_hints(io, ex) |
Member
There was a problem hiding this comment.
Can we keep that line? The goal of #39850 was to allow packages to add hints similar to the LegacyStrings one.
Member
Author
There was a problem hiding this comment.
I suppose that doesn't hurt? I don't know that the API premise of Experimental.show_error_hints is, but I suppose an InteractiveUtils or REPL package might decide to spell check these or something
Member
There was a problem hiding this comment.
As far as API premises go, I think we probably just want to document the kinds of errors register_error_hint! supports and add them as users request them. We don't have that many error types anyways.
simeonschaub
removed
the
merge me
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
Looks like this got lost in deprecation removal?
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
Looks like this got lost in deprecation removal?
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Looks like this got lost in deprecation removal?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this got lost in deprecation removal?