Skip to content

Actually overload Base's escape_string #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2024
Merged

Actually overload Base's escape_string #74

merged 1 commit into from
Aug 4, 2024

Conversation

@tecosaur
Copy link
Member

@tecosaur tecosaur commented Aug 4, 2024

Ooops. Fixes #72.

@tecosaur
Actually overload Base's escape_string
6d3f44d 
While part of the code brought over from Base (or rather a PR to Base)
in 745385d, it was missed when adding the relevant imports to
overload the Base methods.

The main impact of this was slow 3-arg show performance, as raised in
issue #72.
@tecosaur tecosaur mentioned this pull request Aug 4, 2024
Closed
@tecosaur tecosaur merged commit 6d3f44d into main Aug 4, 2024
@tecosaur tecosaur deleted the actually-overload-escapestring branch August 4, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Showing an AnnotatedString is O(length_string * num_annotations)

1 participant

@tecosaur