simplify code for creating a SimpleColor from a UInt32
#71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yep, it would be good to get rid of the needless temp arrays, what about doing it like this though? function SimpleColor(rgb::UInt32)
_, g, b, r = reinterpret(NTuple{4, UInt8}, rgb)
SimpleColor(r, g, b)
endIf you're onboard with this, I'll update the PR and merge it. |
Instead of creating a temporary array that we reinterpret into another temporary array, we can just pick out the bytes we want from within the UInt32.
|
Yep, makes sense as well! |
tecosaur
force-pushed
the
kc/simple_shift
branch
from
e6796c1 to
4d04102
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creating a new Julia array that gets reinterpreted etc can be avoided by just picking out the bytes we want