Skip to content

Conversation

@LilithHafner
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #15 (21cf108) into main (63ff132) will not change coverage.
The diff coverage is n/a.

❗ Current head 21cf108 differs from pull request most recent head 0463684. Consider uploading reports for the commit 0463684 to get more accurate results

@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   67.21%   67.21%           
=======================================
  Files           7        7           
  Lines         796      796           
=======================================
  Hits          535      535           
  Misses        261      261           

@tecosaur
Copy link
Member

The irony here is somewhat funny. Yes, let's make codecov quieter.

@LilithHafner
Copy link
Member Author

I'm unsure whether the second try works because codecov typically only posts one comment.

@LilithHafner
Copy link
Member Author

haha, no I'm sure it didn't work. I forgot to commit the actual fix.

@LilithHafner
Copy link
Member Author

Looking at LilithHafner#1 and LilithHafner#2, I am thoroughly confused, but reading the documentation and validating with https://api.codecov.io/validate, I'm optimistic that this is the right approach and will work.

@tecosaur tecosaur merged commit 41c8218 into main Oct 28, 2023
@tecosaur tecosaur deleted the lh/ci-codecov branch October 28, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants