Reliable quadrant #652
Merged
Reliable quadrant #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpsanders
reviewed
May 26, 2024
|
|
||
| lo_quadrant = _quadrant(lo) | ||
| hi_quadrant = _quadrant(hi) | ||
| lo_quadrant = _quadrant(min, lo) |
There was a problem hiding this comment.
Why do you need the min and max here?
There was a problem hiding this comment.
_quadrant may return two distinct integers. What min/max aims to do is to "overshoot" the quadrants: for the lowest (resp. largest) value of the interval, we want the smallest (resp. largest) quadrant.
dpsanders
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a reliable code to determine quadrants for trigonometric functions.
@dpsanders do you mind having a look?
Closes #622