Skip to content

Conversation

@cserteGT3
Copy link

@cserteGT3 cserteGT3 commented Apr 24, 2019

For my application a function was missing: getting all the parents of a cell. This PR adds this function (similar to the other all...() functions).
Edit: I did not write a test for it.

@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #21 into master will decrease coverage by 1.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   80.41%   79.09%   -1.33%     
==========================================
  Files           5        5              
  Lines          97      110      +13     
==========================================
+ Hits           78       87       +9     
- Misses         19       23       +4
Impacted Files Coverage Δ
src/RegionTrees.jl 100% <ø> (ø) ⬆️
src/cell.jl 76.66% <100%> (+2.66%) ⬆️
src/hyperrectangle.jl 90% <0%> (-10%) ⬇️
src/twosarray.jl 72.22% <0%> (-4.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c522748...91996e9. Read the comment docs.

@rdeits
Copy link
Collaborator

rdeits commented Apr 26, 2019

Looks good, thanks! Could you please add a test for the new function?

@cserteGT3
Copy link
Author

Sorry for the late reply (had to finish the semester), I added some tests for the new function.
I'm not experienced in writing tests, so please review it, if they meet the goal.

@rdeits
Copy link
Collaborator

rdeits commented May 31, 2019

Thank you, this looks great!

@rdeits rdeits merged commit 3f8836b into JuliaGeometry:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants