Improvements for drawing random numbers #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
AbstractRNG
parameter toquatrand
andnquatrand
.It also implements the necessary overloads to call methods like
Base.rand(Quaternion{Float64}, 10)
andBase.randn(Quaternion{Float64}, 10)
. These behave differently fromquatrand
, instead following the pattern set in base byBase.rand(<:Complex)
. Namely,rand
draws each of the four real numbers from the interval[0,1]
.randn
draws from the proper Quaternion normal distribution, which requires a scaling by1/sqrt(4)
(as opposed toComplex
which uses a scaling of1/sqrt(2)
).