CompatHelper: bump compat for FillArrays to 1, (keep existing compat) #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theogf
force-pushed
the
compathelper/new_version/2023-03-31-01-03-33-101-03120445237
branch
from
4fd6f0f to
bcf7672
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 52 52
Lines 1374 1374
=======================================
Hits 1295 1295
Misses 79 79 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Member
|
It appears that FillArrays 1.0 is now being used, so we can safely merge this when CI passes |
theogf
approved these changes
Apr 11, 2023
theogf
deleted the
compathelper/new_version/2023-03-31-01-03-33-101-03120445237
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
FillArrayspackage from0.10, 0.11, 0.12, 0.13to0.10, 0.11, 0.12, 0.13, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.