This repository was archived by the owner on Mar 12, 2021. It is now read-only.
Nerf cu #576
Merged
Nerf cu #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
to FluxML/Flux.jl
that referenced
this pull request
Feb 3, 2020
1013: Adapt to GPUArrays/CuArrays changes r=dhairyagandhi96 a=maleadt Changes in response to JuliaGPU/GPUArrays.jl@a29df67 and JuliaGPU/CuArrays.jl#576. I suppose the next CuArrays release will need to be breaking because of this. Maybe the `crossentropy` signature needs to be adjusted to support integer vectors, but I'll leave that decision up to Flux developers. This at least is the quick fix to get the tests passing again. Co-authored-by: Tim Besard <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it more reasonable, and only convert to Float32 when dealing with arrays of floats.
Fixes #506, where the integer SubArray indices were converted to Float32 too.
Also reverts #522, because I realized it was wrong (not honoring the special Float32 conversion rules). @baggepinnen, why did you need this? The
adapt-based functionality is inherently value based. However,adapt(CuArray, ...)not behaves as expected, so maybe you can use that?