By default, make query column names unique #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #253. Most data formats have requirements around column name uniqueness, including DataFrames.jl. The proposed changes here ensure query result columns are unique by default, while still allowing column names to be duplicated if they pass `allowduplicates=true` to `DBInterface.execute`.
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 83.19% 83.41% +0.21%
==========================================
Files 5 5
Lines 607 615 +8
==========================================
+ Hits 505 513 +8
Misses 102 102
Continue to review full report at Codecov.
|
bkamins
reviewed
Aug 12, 2021
Co-authored-by: Bogumił Kamiński <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253. Most data formats have requirements around column name
uniqueness, including DataFrames.jl. The proposed changes here ensure
query result columns are unique by default, while still allowing column
names to be duplicated if they pass
allowduplicates=truetoDBInterface.execute.