Skip to content

Conversation

@icweaver
Copy link
Member

@icweaver icweaver commented Oct 28, 2025

Hi all, this monorepo seemed like it might be a good use case for the new [workspace] and ParallelTestRunner.jl frameworks, so I thought I'd give it a try. I'm still learning how to use both, so any comments on how this could be improved, or if it even makes sense to use them in this context, is appreciated!

cc @giordano because of your immense help with getting ParallelTestRunner going in Photometry.jl and BackgroundMeshes.jl

What's changed

  • bumped LTS to julia v1.10 (can remove from this PR)
  • used [workspace] project-wide
  • used ParallelTestRunner.jl for sub-package tests
    • refactored tests into their own files to try and take advantage of parallel testing

Wall times for runtest (from test CI)

main 3f11862 3f11862 / main speedup
AstrodynamicalCalculations.jl 34s 46s 1.35
AstrodynamicalModels.jl 10m 05s 09m 33s 0.95
AstrodynamicalSolvers.jl 10m 17s 13m 24s 1.30

Things look generally worse so far...

To explore

  • Not sure if makes sense, but can ParallelTestRunner also be applied at the top-level to simplify GeneralAstrodynamics.jl/test/runtests.jl and .github/workflows/Tests.yml?
  • Pass test args to Tests.yml
  • Does [workspace] cause precompilation time to increase significantly?
  • Would trying to load balance the tests help with the timings measured in CI?

Todo

  • Add some brief dev docs

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.43%. Comparing base (e44419b) to head (3f11862).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   56.43%   56.43%           
=======================================
  Files          13       13           
  Lines        1212     1212           
=======================================
  Hits          684      684           
  Misses        528      528           
Flag Coverage Δ
AstrodynamicalCalculations.jl 51.09% <100.00%> (ø)
AstrodynamicalModels.jl 67.97% <ø> (ø)
AstrodynamicalSolvers.jl 64.62% <ø> (ø)
GeneralAstrodynamics.jl 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@icweaver icweaver marked this pull request as ready for review October 28, 2025 11:17
@icweaver icweaver requested a review from cadojo October 28, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant