use Base.promote_op instead of Core.Compiler.return_type
#303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves to using a documented interface from a compiler internal interface (and at the same time, fixes the issues with `Tuple{Union{}}` on 1.10).
Would be useful to add a test demonstrating what's fixed here. I think |
|
Gentle bump. Even without an explicit test, I think this is a good change. |
|
I also agree, even though it doesn't really fix anything AFAIK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves to using a semi-documented interface from a compiler internal function (and at the same time, fixes the issues with
Tuple{Union{}}on 1.10).