implement specialization of Base.dataids to speed-up broadcast
#196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piever
reviewed
Aug 25, 2021
|
Thanks! I've added a small comment because I think this implementation does not respect the docstring from Base. Would you mind also adding a test for this method? |
Co-authored-by: Pietro Vertechi <[email protected]>
Good point - added in 5e87976 |
piever
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another part of an effort to improve the performance of some of our numerical simulation methods for partial differential equations in Trixi.jl. Adding this on top of the changes introduced in #194, this increases the performance of some of our numerical methods by ca. one third.