Inline get_ith
#177
Merged
Inline get_ith
#177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add `@inline` to the `get_ith` function. This avoids dynamic function calls when accessing elements of a `StructArray`. This allows accessing elements of `StructArray`s in GPU kernels.
lcw
added a commit
to lcw/Bennu.jl
that referenced
this pull request
Apr 5, 2021
This adds the necessary functionality to run a `StructArray` with elements of type `SArray`. For this to work on the GPU we need to inline a couple of functions in StructArrays, see <JuliaArrays/StructArrays.jl#177>.
lcw
added a commit
to lcw/Bennu.jl
that referenced
this pull request
Apr 6, 2021
This adds the necessary functionality to run a `StructArray` with elements of type `SArray`. For this to work on the GPU we need to inline a couple of functions in StructArrays, see <JuliaArrays/StructArrays.jl#177>.
lcw
added a commit
to lcw/Bennu.jl
that referenced
this pull request
Apr 6, 2021
This adds the necessary functionality to run a `StructArray` with elements of type `SArray`. For this to work on the GPU we need to inline a couple of functions in StructArrays, see <JuliaArrays/StructArrays.jl#177>.
lcw
added a commit
to lcw/Bennu.jl
that referenced
this pull request
Apr 6, 2021
This adds the necessary functionality to run a `StructArray` with elements of type `SArray`. For this to work on the GPU we need to inline a couple of functions in StructArrays, see <JuliaArrays/StructArrays.jl#177>.
|
LGTM, thanks! |
|
Thanks for merging! Would it be possible to get a release tagged with this change? |
|
Sure! I've just tagged a patch release JuliaRegistries/General#33769 |
|
Awesome! |
lcw
added a commit
to lcw/Bennu.jl
that referenced
this pull request
Apr 7, 2021
This updates StructArrays to a version that includes <JuliaArrays/StructArrays.jl#177> which is required for kernels to read elements from a `StructArray`.
lcw
added a commit
to lcw/Bennu.jl
that referenced
this pull request
Apr 20, 2021
This updates StructArrays to a version that includes <JuliaArrays/StructArrays.jl#177> which is required for kernels to read elements from a `StructArray`.
lcw
added a commit
to lcw/Bennu.jl
that referenced
this pull request
Apr 28, 2021
This updates StructArrays to a version that includes <JuliaArrays/StructArrays.jl#177> which is required for kernels to read elements from a `StructArray`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add
@inlineto theget_ithfunction. This avoids dynamicfunction calls when accessing elements of a
StructArray. This allowsaccessing elements of
StructArrays in GPU kernels.