Skip to content

Do recursive bit during code generation in foreachfield #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Do recursive bit during code generation in foreachfield #141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
963be22
do recursive bit inside foreachfield codegen
piever Jul 17, 2020
d3b2ada
minor cleanup
piever Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 24 additions & 11 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,27 +28,40 @@ else
const _getproperty = getproperty
end

function _foreachfield(names, L)
array_names_types(::Type{StructArray{T, N, C, I}}) where {T, N, C, I} = array_names_types(C)
array_names_types(::Type{NamedTuple{names, types}}) where {names, types} = zip(names, types.parameters)
array_names_types(::Type{T}) where {T<:Tuple} = enumerate(T.parameters)

function apply_f_to_vars_fields(names_types, vars)
exprs = Expr[]
for (name, type) in names_types
sym = QuoteNode(name)
args = [Expr(:call, :_getproperty, var, sym) for var in vars]
expr = if type <: StructArray
apply_f_to_vars_fields(array_names_types(type), args)
else
Expr(:call, :f, args...)
end
push!(exprs, expr)
end
return Expr(:block, exprs...)
end

function _foreachfield(names_types, L)
vars = ntuple(i -> gensym(), L)
exprs = Expr[]
for (i, v) in enumerate(vars)
push!(exprs, Expr(:(=), v, Expr(:call, :getfield, :xs, i)))
end
for field in names
sym = QuoteNode(field)
args = [Expr(:call, :_getproperty, var, sym) for var in vars]
push!(exprs, Expr(:call, :f, args...))
end
push!(exprs, apply_f_to_vars_fields(names_types, vars))
push!(exprs, :(return nothing))
return Expr(:block, exprs...)
end

@generated foreachfield_gen(::NamedTuple{names}, f, xs::Vararg{Any, L}) where {names, L} =
_foreachfield(names, L)
@generated foreachfield_gen(::NTuple{N, Any}, f, xs::Vararg{Any, L}) where {N, L} =
_foreachfield(Base.OneTo(N), L)
@generated foreachfield_gen(::S, f, xs::Vararg{Any, L}) where {S<:StructArray, L} =
_foreachfield(array_names_types(S), L)

foreachfield(f, x::StructArray, xs...) = foreachfield_gen(fieldarrays(x), f, x, xs...)
foreachfield(f, x::StructArray, xs...) = foreachfield_gen(x, f, x, xs...)

"""
`iscompatible(::Type{S}, ::Type{V}) where {S, V<:AbstractArray}`
Expand Down