Skip to content

Conversation

piever
Copy link
Collaborator

@piever piever commented Feb 14, 2020

Now foreachfield relies on Tables.getcolumn.

Multidimensional StructArray are also treated as tables.

TODO

  • Fully support Tables interface for LazyRows as well? (left for later PR)

@codecov-io
Copy link

codecov-io commented Feb 14, 2020

Codecov Report

Merging #119 into master will decrease coverage by 4.95%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   94.59%   89.63%   -4.96%     
==========================================
  Files          10       10              
  Lines         407      386      -21     
==========================================
- Hits          385      346      -39     
- Misses         22       40      +18
Impacted Files Coverage Δ
src/StructArrays.jl 100% <ø> (ø) ⬆️
src/lazy.jl 96.42% <100%> (-3.58%) ⬇️
src/utils.jl 85.96% <100%> (-7.98%) ⬇️
src/tables.jl 75% <83.33%> (-9.62%) ⬇️
src/interface.jl 83.33% <0%> (-16.67%) ⬇️
src/collect.jl 95.77% <0%> (-4.23%) ⬇️
src/structarray.jl 85.56% <0%> (-6.44%) ⬇️
src/groupjoin.jl 86.66% <0%> (-4.25%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace794f...b6490fe. Read the comment docs.

@piever piever changed the title switch to getcolumn and support tables in ND StructArray WIP: switch to getcolumn and support tables in ND StructArray Feb 14, 2020
@piever piever changed the title WIP: switch to getcolumn and support tables in ND StructArray switch to getcolumn and support tables in ND StructArray Feb 14, 2020
@piever piever merged commit 0c5a47a into master Feb 14, 2020
@piever piever deleted the pv/column branch February 14, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants