Skip to content

Conversation

tkf
Copy link
Member

@tkf tkf commented Feb 12, 2020

This PR simplifies and improves Tables.jl integration by using Tables.isrowtable introduced by JuliaData/Tables.jl#134. This patch requires Tables v1.0 which is not released yet. So I'm posting it as a WIP PR for now.

This PR combined with JuliaData/TypedTables.jl#57 makes append!(::TypedTables.Table, ::StructArray) work column-by-column as an optimization.

@tkf tkf marked this pull request as ready for review February 12, 2020 07:17
@codecov-io
Copy link

codecov-io commented Feb 12, 2020

Codecov Report

Merging #116 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #116      +/-   ##
=========================================
- Coverage   95.62%   95.6%   -0.03%     
=========================================
  Files          10      10              
  Lines         389     387       -2     
=========================================
- Hits          372     370       -2     
  Misses         17      17
Impacted Files Coverage Δ
src/tables.jl 100% <50%> (ø) ⬆️
src/interface.jl 100% <0%> (ø) ⬆️
src/utils.jl 98.21% <0%> (ø) ⬆️
src/groupjoin.jl 90.9% <0%> (ø) ⬆️
src/collect.jl 100% <0%> (ø) ⬆️
src/lazy.jl 100% <0%> (ø) ⬆️
src/structarray.jl 92% <0%> (ø) ⬆️
src/sort.jl 93.97% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8e0ab...48bc36f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants