Skip to content

Conversation

piever
Copy link
Collaborator

@piever piever commented Dec 31, 2019

This fixes the dispatch for push! and append! and adds an optimized append!! method when the iterator being appended is an AbstractVector.

TODO:

  • Add tests.

@codecov-io
Copy link

codecov-io commented Jan 1, 2020

Codecov Report

Merging #111 into master will decrease coverage by 1.88%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   91.37%   89.48%   -1.89%     
==========================================
  Files          10       10              
  Lines         371      371              
==========================================
- Hits          339      332       -7     
- Misses         32       39       +7
Impacted Files Coverage Δ
src/structarray.jl 88.29% <ø> (+1.69%) ⬆️
src/collect.jl 92.95% <71.42%> (-2.64%) ⬇️
src/lazy.jl 84.61% <0%> (-11.54%) ⬇️
src/utils.jl 85.18% <0%> (-7.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5099132...4dbf5bd. Read the comment docs.

@piever piever merged commit b562bec into master Jan 1, 2020
@piever piever deleted the pv/append branch January 1, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants