Added support for CuArray via Adapt.jl #67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piever
requested changes
Dec 20, 2023
|
Thanks for the PR, I've left a review with some suggestions. I'll be traveling for the holidays so I might be slow in responding for the next couple of weeks. |
Co-authored-by: Pietro Vertechi <[email protected]>
Co-authored-by: Pietro Vertechi <[email protected]>
Co-authored-by: Pietro Vertechi <[email protected]>
|
... there were a couple of typos. Now the |
|
Can we move ahead as is (with the optional CUDA testing)? If not, we can also make the tests CUDA-dependent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This second attempt, uses a very light-weight implementation to add
CuArraysupport toShiftedArrays.jl.It is based on using an Extension Package, such that
ShiftedArraysdoes not drag in any extra packages, but ifCUDA.jlis present, the adaptation is used.Note that the
show()function was specified by CuArrays preventing errors via the@allowscalarmacro.The tests were extended to CuArray usage, but this has to be enabled manually in the
runtests.jlfile.