Fix dimensions for row view of a vcat #388
Open
+35
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 95.89% 95.90% +0.01%
==========================================
Files 17 17
Lines 3360 3372 +12
==========================================
+ Hits 3222 3234 +12
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dlfivefifty
changed the title
dlfivefifty
changed the title
Collaborator
|
Is this good to go now? Or did you want more work done on it? |
Member
Author
|
Can we get codecov up? |
Collaborator
|
Will look into InfiniteArrays.jl's broken test... that wasn't failing after df9bc03 (https://github.com/JuliaArrays/LazyArrays.jl/actions/runs/19538293736/job/55937738184). |
Collaborator
|
Actually that downstream test is also failing on #389 so I'm not sure it's related to this PR anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.