Skip to content

Conversation

Tokazama
Copy link
Member

@Tokazama Tokazama commented Nov 7, 2022

Fix #363 which was caused by removal of setindex in #305

Fix #363 which was caused by removal of  `setindex` in #305
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #365 (acd1476) into master (87e65bc) will increase coverage by 90.27%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #365       +/-   ##
===========================================
+ Coverage    0.00%   90.27%   +90.27%     
===========================================
  Files           9        9               
  Lines        1335     1337        +2     
===========================================
+ Hits            0     1207     +1207     
+ Misses       1335      130     -1205     
Impacted Files Coverage Δ
src/indexing.jl 84.29% <0.00%> (+84.29%) ⬆️
src/ArrayInterface.jl 85.96% <0.00%> (+85.96%) ⬆️
src/stridelayout.jl 89.89% <0.00%> (+89.89%) ⬆️
src/size.jl 91.89% <0.00%> (+91.89%) ⬆️
src/axes.jl 92.02% <0.00%> (+92.02%) ⬆️
src/ranges.jl 92.46% <0.00%> (+92.46%) ⬆️
src/dimensions.jl 93.87% <0.00%> (+93.87%) ⬆️
src/broadcast.jl 100.00% <0.00%> (+100.00%) ⬆️
src/array_index.jl 100.00% <0.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Tokazama Tokazama merged commit 9e58cb2 into master Nov 7, 2022
@Tokazama Tokazama deleted the rm-setindex branch November 7, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of setindex causes test failures
1 participant