Skip to content

Conversation

ChrisRackauckas
Copy link
Member

Since this will likely be needed in a lot more places.

@ChrisRackauckas ChrisRackauckas merged commit 70d177a into master Feb 2, 2020
@ChrisRackauckas ChrisRackauckas deleted the aos branch February 2, 2020 19:04

Converts an array of structs formulation to a struct of array
"""
aos_to_soa(x) = x

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit late on this, but aos_to_soa does not read that well, two not-that-known abbreviations in an exported function

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but anything I could think of was excessively long, so 🤷‍♂

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

structarray_to_arraystruct? rowarray_to_colarray? There should be a similar name in the data ecosystems

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rowarray_to_colarray doesn't work since it really is more general structs. structarray_to_arraystruct would be possible.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively, writing one of them in full letter and the second in abbreviation also works, since they are redundant, structarray_to_aos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ehh I like the symmetry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants