Skip to content

Fixing the ArrayInterfaceCUDA lu_instance test #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2022
Merged

Fixing the ArrayInterfaceCUDA lu_instance test #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1dabc4a
Add a test for the lu_instance function
TheZombie1999 Sep 8, 2022
c70af9c
Add a test for the lu_instance function
TheZombie1999 Sep 8, 2022
1ed38f2
Make Test an test dependency
TheZombie1999 Sep 8, 2022
c9be654
Update lib/ArrayInterfaceCUDA/Project.toml
ChrisRackauckas Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/ArrayInterfaceCUDA/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,9 @@ ArrayInterface = "5, 6"
ArrayInterfaceGPUArrays = "0.1"
CUDA = "3.9"
julia = "1.6"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Test"]
1 change: 1 addition & 0 deletions lib/ArrayInterfaceCUDA/src/ArrayInterfaceCUDA.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module ArrayInterfaceCUDA
using Adapt
using ArrayInterface, ArrayInterfaceGPUArrays
using CUDA
using CUDA.CUSOLVER

using LinearAlgebra

Expand Down
10 changes: 7 additions & 3 deletions lib/ArrayInterfaceCUDA/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
using ArrayInterfaceCUDA, CUDA, Test
using CUDA
using ArrayInterface
using ArrayInterfaceCUDA

A = cu(rand(4,4))
@test ArrayInterface.lu_instance(A) isa CUDA.CUSOLVER.CuQR
using Test

# Test whether lu_instance throws an error when invoked with an gpu array
@test !isa(try ArrayInterface.lu_instance(CUDA.CuArray([1.f0 1.f0; 1.f0 1.f0])) catch ex ex end, Exception)