Support "known" methods in ArrayInterfaceCore #335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
- Coverage 90.06% 89.36% -0.71%
==========================================
Files 9 9
Lines 1319 1175 -144
==========================================
- Hits 1188 1050 -138
+ Misses 131 125 -6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if/when we'll get Base support for
StaticIntbut it would be nice if everybody at least had the tools to support the most of the stride layout irrelevant of that decision going forward. This attempts to get all the "known" traits into the core package. If this looks good we might be able to figure out how to work this into thesize,length,offsetsandstridesmethods here so it's easier to support those without a direct dependency on ArrayInterface for those hesitant about Static.jlThe downside to this is that we can't fall back to
axes_typesto extract information, which requires manually defining more methods and might even be breaking. I figured it was worth trying anyway because at the very least it will demonstrate that we really have tried everything to get aroundStaticInt.