Skip to content

Conversation

Tokazama
Copy link
Member

Previous versions were trying to use firstindex and lastindex to reference an axis but first(axis) and last(axis) is what we actually want and is faster.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #319 (c26988e) into master (5228630) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   91.86%   91.79%   -0.07%     
==========================================
  Files           9        9              
  Lines        1439     1439              
==========================================
- Hits         1322     1321       -1     
- Misses        117      118       +1     
Impacted Files Coverage Δ
src/indexing.jl 89.34% <100.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5228630...c26988e. Read the comment docs.

@Tokazama
Copy link
Member Author

@ChrisRackauckas, I'm assuming those SciMLBase failures are unrelated?

@ChrisRackauckas
Copy link
Member

Passed in the second run. Thanks for letting me know, that was a goof on my end.

@ChrisRackauckas ChrisRackauckas merged commit 2f95c1d into master Jun 22, 2022
@ChrisRackauckas ChrisRackauckas deleted the functional-index-performance branch June 22, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants