Index trait for resulting array's shape #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 9 9
Lines 1399 1399
=======================================
Hits 1280 1280
Misses 119 119 Continue to review full report at Codecov.
|
chriselrod
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the problem that #297 was working around was the absence of any information related to how an index type translates into the shape of the resulting array. Some of the problems discussed in #312 are also related to this. I'll be following this up with a couple internal changes in ArrayInterface, but I want to do this piecewise to ensure I don't break anything by changing it all at once.